Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTP-21] chore(origin detection): add External Data E2E test #31079

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[CONTP-21] chore(origin detection): add External Data E2E test #31079

merged 1 commit into from
Nov 26, 2024

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Nov 14, 2024 •
edited
Loading

What does this PR do?

Adds an E2E test to validate that the External Data resolution for Origin Detection works as expected.

Motivation

This is needed to ensure that Origin Detection keep working as expected

Describe how to test/QA your changes

N/A

Possible Drawbacks / Trade-offs

N/A

Additional Notes

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team labels Nov 14, 2024
@wdhif wdhif added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 14, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 14, 2024 •
edited
Loading

[Fast Unit Tests Report]

On pipeline 49770718 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 14, 2024 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49770718 --os-family=ubuntu

Note: This applies to commit 646bcca

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 14, 2024 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 891dbf10-b3e8-478b-b5e9-78ee9fe34ad6

Baseline: c33fab7
Comparison: 646bcca
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
❌ basic_py_check % cpu utilization +7.10 [+3.21, +10.99] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
❌ basic_py_check % cpu utilization +7.10 [+3.21, +10.99] 1 Logs
➖ file_tree memory utilization +2.21 [+2.06, +2.35] 1 Logs
➖ quality_gate_idle_all_features memory utilization +1.61 [+1.51, +1.72] 1 Logs bounds checks dashboard
➖ pycheck_lots_of_tags % cpu utilization +1.32 [-2.21, +4.85] 1 Logs
➖ quality_gate_idle memory utilization +1.29 [+1.22, +1.36] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.40 [-0.06, +0.86] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.37 [-0.41, +1.15] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.06 [-0.68, +0.80] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.03 [-0.70, +0.76] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.03 [-0.80, +0.86] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.11] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.05 [-0.67, +0.58] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.55 [-0.62, -0.49] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.77 [-1.54, -0.00] 1 Logs
➖ otel_to_otel_logs ingress throughput -1.80 [-2.48, -1.13] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_idle memory_usage 8/10 bounds checks dashboard
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 8/10 replicas passed. Failed 2 which is > 0. Gate FAILED.

@wdhif wdhif force-pushed the CONTP-358/wassim.dhif/e2e-test-external-data branch 8 times, most recently from 55a64c5 to 86294db Compare November 21, 2024 12:50
@wdhif wdhif changed the title chore(origin detection): add External Data E2E test CONTP-21: chore(origin detection): add External Data E2E test Nov 21, 2024
@wdhif wdhif force-pushed the CONTP-358/wassim.dhif/e2e-test-external-data branch 2 times, most recently from 10438ff to 33f45ce Compare November 22, 2024 14:17
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 22, 2024
@wdhif wdhif force-pushed the CONTP-358/wassim.dhif/e2e-test-external-data branch from 23a5592 to 8aff12f Compare November 22, 2024 16:47
@wdhif wdhif force-pushed the CONTP-358/wassim.dhif/e2e-test-external-data branch from 8aff12f to 646bcca Compare November 22, 2024 20:38
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Nov 22, 2024
@wdhif wdhif changed the title CONTP-21: chore(origin detection): add External Data E2E test [CONTP-21] chore(origin detection): add External Data E2E test Nov 22, 2024
@wdhif wdhif marked this pull request as ready for review November 23, 2024 14:37
@wdhif wdhif requested review from a team as code owners November 23, 2024 14:37
@wdhif
Copy link
Member Author

wdhif commented Nov 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 26, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-26 12:27:49 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit d03c3af into main Nov 26, 2024
215 checks passed
@dd-mergequeue dd-mergequeue bot deleted the CONTP-358/wassim.dhif/e2e-test-external-data branch November 26, 2024 12:49
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L3n41c L3n41c L3n41c approved these changes

@clamoriniere clamoriniere clamoriniere approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team
Projects
None yet
Milestone
7.61.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wdhif @clamoriniere @L3n41c